Label Templates: rework collection of 'hostinfo' data and collected variables #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/operator
Allow automatic conversion of data to map[string]interface{} (Template
Labels format) using reflection where all data can be useful.
Still do manual collection of data in the map[string]interface{} when
dropping of part of the data is needed.
Use the original hostinfo field names, drop spaces in the keys.
Import also the SMBIOS data from hostinfo, since are there (so also
without dmidecode tool some SMBIOS info will be available).
Keep support of old HARDWARE variable (to be deprecated sooner or
later).
Signed-off-by: Francesco Giudici <[email protected]>
fgiudici
force-pushed
the
label-templates-rework2
branch
2 times, most recently
from
fbcc93a
to
7c3ea82
Compare
notably the "label" output format, which is now the default Signed-off-by: Francesco Giudici <[email protected]>
we don't want to break possible setups using the older Label Templates variables: send both. Signed-off-by: Francesco Giudici <[email protected]>
Signed-off-by: Francesco Giudici <[email protected]>
fgiudici
force-pushed
the
label-templates-rework2
branch
from
7c3ea82
to
8a46a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite some changes in this PR:
System Informationdata still transmitted in parallel but deprecated (and when removed we can drop also the dmidecode tool requirement).The
elemental-registry dumpcommand now allows to print the three label data sets ('smbios', 'legacy' and 'hostinfo', where 'hostinfo' is the new set) in different formats (actual labels, json or yaml).Fixes #834
Replaces #840