Allow configuration of max snapshots during install #851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rancher/elemental-toolkit#2193
Note that the default (and minimum value) now is
2
. This differs from the previous4
forbtrfs
snapshotter (was driven toolkit side).Also note that this covers
install
phase only.I considered implementing it for reset as well, however since you will actually be able to define a different snapshotter config on reset, this will make machine drift in behavior, depending if they are freshly provisioned or reset, which is not desirable imho.
Changing snapshotter type on reset also has consequences, for example switching from
btrfs
toloopdevice
will have serious effects on partition sizes. Changing the amount of maxSnaps will also affect space available, and repartitioning is something we do not support on reset.