Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build e2e chart locally #852

Merged
merged 16 commits into from
Oct 1, 2024

Conversation

anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Sep 25, 2024

This PR is to address the issue with the chart-PR no longer built on OBS.
That needs to be replaced with a local build of the PR, however this turned out to strangely break some tests.
It's not clear why or how, as they only seem to fail in gha now.
These tests were known to be flaky, but now they are failing consistently.

@anmazzotti anmazzotti requested a review from a team as a code owner September 25, 2024 11:09
@github-actions github-actions bot added area/tests test related changes area/build build related changes labels Sep 25, 2024
@anmazzotti anmazzotti force-pushed the build_e2e_chart_locally branch 2 times, most recently from 0b0bbf0 to 273b7f2 Compare September 25, 2024 11:19
@github-actions github-actions bot added the area/operator operator related changes label Sep 25, 2024
@anmazzotti anmazzotti force-pushed the build_e2e_chart_locally branch 2 times, most recently from ec96303 to 26f4a73 Compare September 25, 2024 13:35
@anmazzotti
Copy link
Contributor Author

I give up.
This works flawlessly on my machine when running LOCAL_BUILD=true make e2e-tests, however it consistently fails on Github Actions due to race condition somewhere I assume.

Can't really figure it out right now. I have the feeling we should refactor these tests eventually.

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany enabled auto-merge (squash) October 1, 2024 12:53
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
@davidcassany davidcassany merged commit 08f6cda into rancher:main Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build related changes area/operator operator related changes area/tests test related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants