Drop setting a custom providerID #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not usre why we were using the elemental:// providerID while this should be something like k3s:// Not only that but it was blocking the correct health check of the clusters due to not finding the provider. Also drops the provider config override from rke2 as it was setting it to an empty value. We should be able to restore if it proves to be needed but doesnt seem to. Signed-off-by: Itxaka <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 29.74% 29.74%
=======================================
Files 5 5
Lines 353 353
=======================================
Hits 105 105
Misses 244 244
Partials 4 4 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not usre why we were using the elemental:// providerID while this should
be something like k3s://
Not only that but it was blocking the correct health check of the
clusters due to not finding the provider.
Also drops the provider config override from rke2 as it was setting it
to an empty value. We should be able to restore if it proves to be
needed but doesnt seem to.
Signed-off-by: Itxaka [email protected]