Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Parthvi Vala <[email protected]>
  • Loading branch information
valaparthvi committed Nov 14, 2024
1 parent 153b514 commit 5c80019
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
4 changes: 2 additions & 2 deletions hosted/eks/p1/p1_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,11 @@ func updateTagsAndLabels(cluster *management.Cluster, client *rancher.Client) {
var err error
tags := map[string]string{
"foo": "bar",
"testCaseID": "144",
"testCaseID": "144-97-143",
}

labels := map[string]string{
"testCaseID": "142",
"testCaseID": "142-99-145",
}

originalClusterTags := *cluster.EKSConfig.Tags
Expand Down
8 changes: 8 additions & 0 deletions hosted/helpers/helper_common.go
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,14 @@ func FilterUIUnsupportedVersions(versions []string, client *rancher.Client) (fil
return
}

// CheckMapElements checks if map1 keys are subset of map2
func CheckMapKeys(map1, map2 map[string]string) (exists bool) {
for key := range map1 {
_, exists = map2[key]
}
return
}

// DefaultK8sVersion receives a list of version sorted in descending order (1.29, 1.28, 1.27, etc.);
// it returns the k8s version to be used by the test depending on forUpgrade param
func DefaultK8sVersion(descVersions []string, forUpgrade bool) (string, error) {
Expand Down

0 comments on commit 5c80019

Please sign in to comment.