Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EKS P1 and Sync tests #202

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Refactor EKS P1 and Sync tests #202

wants to merge 3 commits into from

Conversation

valaparthvi
Copy link
Collaborator

What does this PR do?

  • Move AfterEach to the top layer in every provisioning and import test files.
  • Make k8sVersion and upgradeToVersion local variables for easy tracking.
  • Move Upgrade testing to a separate Context so that more tests can be added easily without having to re-define k8sVersion and upgradeToVersion.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #

Checklist:

  • Squashed commits into logical changes
  • Documentation
  • GitHub Actions (if applicable)

Special notes for your reviewer:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant