Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.v2.10] Mirror missing images only #1528

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

brooksn
Copy link
Contributor

@brooksn brooksn commented Oct 21, 2024

Some images in the rancher registry may have different digests than their counterparts in docker hub. This change ensures images with the same tag but different digests will not be overwritten.

Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For the reference, here is the helper message from regsycn

> regsync once -h
Processes each sync command in the configuration file in order.
No jobs are run in parallel, and the command returns after any error or last
sync step is finished.

Usage:
  regsync once [flags]

Flags:
  -h, --help      help for once
      --missing   Only copy tags that are missing on target

Global Flags:
  -c, --config string        Config file
      --logopt stringArray   Log options
  -v, --verbosity string     Log level (debug, info, warn, error, fatal, panic) (default "info")

@jiaqiluo jiaqiluo requested a review from a team October 25, 2024 21:18
@jiaqiluo
Copy link
Member

hi @brooksn, can you backprot the change to dev-v2.9 and dev-v2.8 after the PR is merged?

Signed-off-by: Brooks Newberry <[email protected]>
@brooksn brooksn merged commit 0447091 into rancher:dev-v2.10 Oct 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants