Fix microos build #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microos uses newer SELinux packages than centos7/8 and is hitting a change in container-selinux that altered the signature for the container_domain_template macro[1]. Update the policy file to account for the changes. [1] containers/container-selinux@24e5784
Merged
cmurphy
requested review from
tomleb and
andypitcher
and removed request for
tomleb
andypitcher
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Tested locally, the changes provided in this PR fixe the compilation of rancher.te.
container_domain_template template now takes container as template_rules, and type container_file_t to be declared.
Here is the diff between the new rancher.te (the one that applies the new template's reqs) and the old rancher.te (that makes the compilation of microos rancher.te policy to fail):
24ea68a0ba04:~/policy/microos # diff rancher.te /tmp/rancher.te_old
5d4
< type container_file_t;
18c17
< container_domain_template(rke_kubereader, container)
---
> container_domain_template(rke_kubereader)
37c36
< container_domain_template(rke_logreader, container)
---
> container_domain_template(rke_logreader)
64c63
< container_domain_template(rke_container, container)
---
> container_domain_template(rke_container)
96c95
< container_domain_template(rke_network, container)
---
> container_domain_template(rke_network)
24ea68a0ba04:~/policy/microos # make -f /usr/share/selinux/devel/Makefile rancher.pp
Compiling targeted rancher module
Creating targeted rancher.pp policy package
rm tmp/rancher.mod.fc tmp/rancher.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microos uses newer SELinux packages than centos7/8 and is hitting a change in
container-selinuxthat altered the signature for the container_domain_template macro[1]. Update the policy file to account for the changes.[1] containers/container-selinux@24e5784