-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dynamic configmap-nodelocal #474
base: main-source
Are you sure you want to change the base?
Conversation
add dynamic to configmap node-local-dns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to bump the packageVersion when changing the chart patches, if you are not also pulling in a new chart version from upstream:
packageVersion: 02 |
update packageVersion
packages/rke2-coredns/generated-changes/overlay/templates/configmap-nodelocal.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. One nit on the whitespace.
Can you please open an issue at https://github.com/rancher/rke2/issues describing your use case, and provide example chart values to allow our QA team to test this change?
Can you show example values for how to use this? You should also patch the rke2-charts/charts/rke2-coredns/rke2-coredns/1.29.002/values.yaml Lines 388 to 399 in ca72e83
If the section shouldn't be present by default, add it commented out - for example: rke2-charts/charts/rke2-coredns/rke2-coredns/1.29.002/values.yaml Lines 374 to 378 in ca72e83
|
I tried just copying the default nodelocal:
enabled: true
servers:
- plugins:
- name: errors
- configBlock: lameduck 5s
name: health
- name: ready
- configBlock: |-
pods insecure
fallthrough in-addr.arpa ip6.arpa
ttl 30
name: kubernetes
parameters: cluster.local in-addr.arpa ip6.arpa
- name: prometheus
parameters: 0.0.0.0:9153
- name: forward
parameters: . /etc/resolv.conf
- name: cache
parameters: 30
- name: loop
- name: reload
- name: loadbalance
port: 53
zones:
- zone: .
|
add dynamic to configmap node-local-dns