Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed systemctl command from 'restart' to 'try-restart' for fapolicyd in rke2-uninstall.sh #5811

Merged
merged 1 commit into from
May 28, 2024

Conversation

burlyunixguy
Copy link
Contributor

This fix will prevent fapolicyd service from inadvertently starting if the previous state was disabled.

Proposed Changes

  • Change 'restart' to 'try-restart' for systemctl option. Currently, if fapolicyd is disabled and not running, the 'restart' option will start fapolicyd even if it was disabled.

  • No documentation update necessary.

Types of Changes

Bugfix

Verification

  • set fapolicyd systemd status to 'stopped/inactive' and 'disabled'
  • issue command 'systemctl try-restart fapolicyd' . The status of fapolicyd should remain in 'inactive(dead)' and 'disabled' status.

Testing

  • Pretty simple change.

Linked Issues

User-Facing Change

NONE

Further Comments

…yd. This will prevent fapolicyd service from inadvertantly starting if it was previously disabled.
@burlyunixguy burlyunixguy requested a review from a team as a code owner April 21, 2024 22:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.80%. Comparing base (63fe2ca) to head (6adfc2f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5811      +/-   ##
==========================================
- Coverage   26.46%   18.80%   -7.67%     
==========================================
  Files          30       29       -1     
  Lines        2649     2638      -11     
==========================================
- Hits          701      496     -205     
- Misses       1903     2101     +198     
+ Partials       45       41       -4     
Flag Coverage Δ
inttests ?
unittests 18.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants