-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cilium no proxy e2e test #5885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
requested changes
May 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5885 +/- ##
===========================================
- Coverage 26.46% 10.00% -16.46%
===========================================
Files 30 30
Lines 2649 2649
===========================================
- Hits 701 265 -436
- Misses 1903 2362 +459
+ Partials 45 22 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
requested changes
May 8, 2024
dereknola
approved these changes
May 9, 2024
Signed-off-by: Manuel Buil <[email protected]>
Signed-off-by: Manuel Buil <[email protected]>
Signed-off-by: Manuel Buil <[email protected]>
rbrtbnfgl
reviewed
May 14, 2024
Signed-off-by: Manuel Buil <[email protected]>
rbrtbnfgl
approved these changes
May 14, 2024
mgfritch
approved these changes
May 14, 2024
manuelbuil
added a commit
to manuelbuil/rke2
that referenced
this pull request
May 23, 2024
* Add cilium no proxy e2e test Signed-off-by: Manuel Buil <[email protected]> * Update the old loop Signed-off-by: Manuel Buil <[email protected]> * Replace deprecated exists by exist Signed-off-by: Manuel Buil <[email protected]> * Remove kubelet-arg as it is not needed anymore Signed-off-by: Manuel Buil <[email protected]> --------- Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
added a commit
to manuelbuil/rke2
that referenced
this pull request
May 23, 2024
* Add cilium no proxy e2e test Signed-off-by: Manuel Buil <[email protected]> * Update the old loop Signed-off-by: Manuel Buil <[email protected]> * Replace deprecated exists by exist Signed-off-by: Manuel Buil <[email protected]> * Remove kubelet-arg as it is not needed anymore Signed-off-by: Manuel Buil <[email protected]> --------- Signed-off-by: Manuel Buil <[email protected]>
This was referenced May 23, 2024
manuelbuil
added a commit
to manuelbuil/rke2
that referenced
this pull request
May 23, 2024
* Add cilium no proxy e2e test Signed-off-by: Manuel Buil <[email protected]> * Update the old loop Signed-off-by: Manuel Buil <[email protected]> * Replace deprecated exists by exist Signed-off-by: Manuel Buil <[email protected]> * Remove kubelet-arg as it is not needed anymore Signed-off-by: Manuel Buil <[email protected]> --------- Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
added a commit
that referenced
this pull request
May 27, 2024
* Add cilium no proxy e2e test * Update the old loop * Replace deprecated exists by exist * Remove kubelet-arg as it is not needed anymore --------- Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
added a commit
that referenced
this pull request
May 27, 2024
* Add cilium no proxy e2e test * Update the old loop * Replace deprecated exists by exist * Remove kubelet-arg as it is not needed anymore --------- Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
added a commit
that referenced
this pull request
May 27, 2024
* Add cilium no proxy e2e test * Update the old loop * Replace deprecated exists by exist * Remove kubelet-arg as it is not needed anymore --------- Signed-off-by: Manuel Buil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds a e2e test for cilium without kube-proxy and using BPF. It uses ubuntu2310 because we need a kernel version above 5.10.
This PR also moves a couple of functions to testutils and consequently modifies how other tests are calling those functions
Types of Changes
New test
Verification
go test -v -timeout=25m ./tests/e2e/ciliumnokp/
Testing
Linked Issues
User-Facing Change
Further Comments