Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cilium no proxy e2e test #5885

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented May 6, 2024

Proposed Changes

Adds a e2e test for cilium without kube-proxy and using BPF. It uses ubuntu2310 because we need a kernel version above 5.10.

This PR also moves a couple of functions to testutils and consequently modifies how other tests are calling those functions

Types of Changes

New test

Verification

go test -v -timeout=25m ./tests/e2e/ciliumnokp/

Testing

Linked Issues

User-Facing Change


Further Comments

tests/e2e/scripts/cilium_nokubeproxy.sh Outdated Show resolved Hide resolved
tests/e2e/ciliumnokp/ciliumnokp_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.00%. Comparing base (e966db2) to head (0328dbc).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5885       +/-   ##
===========================================
- Coverage   26.46%   10.00%   -16.46%     
===========================================
  Files          30       30               
  Lines        2649     2649               
===========================================
- Hits          701      265      -436     
- Misses       1903     2362      +459     
+ Partials       45       22       -23     
Flag Coverage Δ
inttests 10.00% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/e2e/ciliumnokp/Vagrantfile Outdated Show resolved Hide resolved
@manuelbuil manuelbuil requested a review from dereknola May 9, 2024 09:51
mgfritch
mgfritch approved these changes May 9, 2024
tests/e2e/ciliumnokp/Vagrantfile Outdated Show resolved Hide resolved
@manuelbuil manuelbuil merged commit 1f4230b into rancher:master May 23, 2024
5 checks passed
@manuelbuil manuelbuil deleted the e2etestcilium branch May 23, 2024 16:55
manuelbuil added a commit to manuelbuil/rke2 that referenced this pull request May 23, 2024
* Add cilium no proxy e2e test

Signed-off-by: Manuel Buil <[email protected]>

* Update the old loop

Signed-off-by: Manuel Buil <[email protected]>

* Replace deprecated exists by exist

Signed-off-by: Manuel Buil <[email protected]>

* Remove kubelet-arg as it is not needed anymore

Signed-off-by: Manuel Buil <[email protected]>

---------

Signed-off-by: Manuel Buil <[email protected]>
manuelbuil added a commit to manuelbuil/rke2 that referenced this pull request May 23, 2024
* Add cilium no proxy e2e test

Signed-off-by: Manuel Buil <[email protected]>

* Update the old loop

Signed-off-by: Manuel Buil <[email protected]>

* Replace deprecated exists by exist

Signed-off-by: Manuel Buil <[email protected]>

* Remove kubelet-arg as it is not needed anymore

Signed-off-by: Manuel Buil <[email protected]>

---------

Signed-off-by: Manuel Buil <[email protected]>
manuelbuil added a commit to manuelbuil/rke2 that referenced this pull request May 23, 2024
* Add cilium no proxy e2e test

Signed-off-by: Manuel Buil <[email protected]>

* Update the old loop

Signed-off-by: Manuel Buil <[email protected]>

* Replace deprecated exists by exist

Signed-off-by: Manuel Buil <[email protected]>

* Remove kubelet-arg as it is not needed anymore

Signed-off-by: Manuel Buil <[email protected]>

---------

Signed-off-by: Manuel Buil <[email protected]>
manuelbuil added a commit that referenced this pull request May 27, 2024
* Add cilium no proxy e2e test



* Update the old loop



* Replace deprecated exists by exist



* Remove kubelet-arg as it is not needed anymore



---------

Signed-off-by: Manuel Buil <[email protected]>
manuelbuil added a commit that referenced this pull request May 27, 2024
* Add cilium no proxy e2e test



* Update the old loop



* Replace deprecated exists by exist



* Remove kubelet-arg as it is not needed anymore



---------

Signed-off-by: Manuel Buil <[email protected]>
manuelbuil added a commit that referenced this pull request May 27, 2024
* Add cilium no proxy e2e test



* Update the old loop



* Replace deprecated exists by exist



* Remove kubelet-arg as it is not needed anymore



---------

Signed-off-by: Manuel Buil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants