Slim down E2E artifacts #6097
Merged
Slim down E2E artifacts #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
reviewed
Jun 3, 2024
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6097 +/- ##
==========================================
- Coverage 26.10% 9.82% -16.29%
==========================================
Files 32 32
Lines 2697 2698 +1
==========================================
- Hits 704 265 -439
- Misses 1947 2411 +464
+ Partials 46 22 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Jun 4, 2024
VestigeJ
approved these changes
Jun 6, 2024
dereknola
added a commit
to dereknola/rke2
that referenced
this pull request
Jun 7, 2024
* Don't use rke2-runtime.tar in e2e Signed-off-by: Derek Nola <[email protected]> * Don't upload rke2-runtime.tar Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/rke2
that referenced
this pull request
Jun 7, 2024
* Don't use rke2-runtime.tar in e2e Signed-off-by: Derek Nola <[email protected]> * Don't upload rke2-runtime.tar Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/rke2
that referenced
this pull request
Jun 7, 2024
* Don't use rke2-runtime.tar in e2e Signed-off-by: Derek Nola <[email protected]> * Don't upload rke2-runtime.tar Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
This was referenced Jun 7, 2024
dereknola
added a commit
that referenced
this pull request
Jun 10, 2024
* Fix loadManifests function (#6058) Signed-off-by: Derek Nola <[email protected]> * Slim down E2E artifacts (#6097) * Don't use rke2-runtime.tar in e2e Signed-off-by: Derek Nola <[email protected]> * Don't upload rke2-runtime.tar Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]> * Add custom golang setup action for better caching (#6144) Signed-off-by: Derek Nola <[email protected]> * Support MixedOS E2E local testing (#6137) * Consolidate CreateWindowsCluster test function Signed-off-by: Derek Nola <[email protected]> * Support local windows builds in mixedOS e2e test Signed-off-by: Derek Nola <[email protected]> * Add mixedos to E2E CI Signed-off-by: Derek Nola <[email protected]> * Simplify local cluster provisioning with libvirt native parallel bringup Signed-off-by: Derek Nola <[email protected]> * Don't run mixedOS on E2E Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Jun 10, 2024
* Fix loadManifests function (#6058) Signed-off-by: Derek Nola <[email protected]> * Slim down E2E artifacts (#6097) * Don't use rke2-runtime.tar in e2e Signed-off-by: Derek Nola <[email protected]> * Don't upload rke2-runtime.tar Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]> * Add custom golang setup action for better caching (#6144) Signed-off-by: Derek Nola <[email protected]> * Support MixedOS E2E local testing (#6137) * Consolidate CreateWindowsCluster test function Signed-off-by: Derek Nola <[email protected]> * Support local windows builds in mixedOS e2e test Signed-off-by: Derek Nola <[email protected]> * Add mixedos to E2E CI Signed-off-by: Derek Nola <[email protected]> * Simplify local cluster provisioning with libvirt native parallel bringup Signed-off-by: Derek Nola <[email protected]> * Don't run mixedOS on E2E Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Jun 10, 2024
* Fix loadManifests function (#6058) Signed-off-by: Derek Nola <[email protected]> * Slim down E2E artifacts (#6097) * Don't use rke2-runtime.tar in e2e Signed-off-by: Derek Nola <[email protected]> * Don't upload rke2-runtime.tar Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]> * Add custom golang setup action for better caching (#6144) Signed-off-by: Derek Nola <[email protected]> * Support MixedOS E2E local testing (#6137) * Consolidate CreateWindowsCluster test function Signed-off-by: Derek Nola <[email protected]> * Support local windows builds in mixedOS e2e test Signed-off-by: Derek Nola <[email protected]> * Add mixedos to E2E CI Signed-off-by: Derek Nola <[email protected]> * Simplify local cluster provisioning with libvirt native parallel bringup Signed-off-by: Derek Nola <[email protected]> * Don't run mixedOS on E2E Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
iamsarthakk
pushed a commit
to iamsarthakk/rke2
that referenced
this pull request
Aug 19, 2024
* Don't use rke2-runtime.tar in e2e Signed-off-by: Derek Nola <[email protected]> * Don't upload rke2-runtime.tar Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola [email protected]
Proposed Changes
rke2-runtime.tarthe install.sh script doesn't handle it andrke2-images.linux-amd64.tar.zstis actually just rke2-runtime compressed. Saves about 100MB in artifact uploads/downloadsTypes of Changes
Verification
CI still Green
Testing
Linked Issues
N/A
User-Facing Change
Further Comments