Add data-dir to uninstall and killall scripts
#6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakefhyde
changed the title
data-dir to uninstall and killall scripts
brandond
requested changes
Jul 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6296 +/- ##
=======================================
Coverage 25.95% 25.95%
=======================================
Files 32 32
Lines 2712 2712
=======================================
Hits 704 704
Misses 1962 1962
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jake Hyde <[email protected]>
jakefhyde
force-pushed
the
6292-add-data-dir-to-uninstall-and-killall
branch
from
38a27a7
to
39d9fe3
Compare
brandond
approved these changes
Jul 10, 2024
manuelbuil
approved these changes
Jul 10, 2024
This was referenced Jul 10, 2024
This was referenced Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add
RKE2_DATA_DIRas an optional environment variable to therke2-killall.sh,rke2-uninstall.sh, andrke2-uninstall.ps1scripts.Types of Changes
Bugfix
Verification
Installing RKE2 with a custom
data-dir(not/var/lib/rancher/rke2), and running the killall and uninstall scripts, verifying assets in/var/lib/rancher/rke2are properly removed.Testing
This is not currently covered by testing, though I would be happy to write an integration test if need be.
Linked Issues
rke2-killall.shscript does not work for user defineddata-dir#6292User-Facing Change
Further Comments
Relates to rancher/rancher#46066.