Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload test logs #6675

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Upload test logs #6675

merged 1 commit into from
Sep 4, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Aug 30, 2024

Proposed Changes

The Basic and Sonobuoy tests run in CI will no longer dump ~4000 lines of logs into the GHA GUI on failure. Instead, the logs will be uploaded and attached to the CI run as an artifact.

You can see a this in action with https://github.com/rancher/rke2/actions/runs/10688205483 (purposely failed to generate artifacts).

Types of Changes

CI Improvement

Verification

Testing

Linked Issues

#6704

User-Facing Change


Further Comments

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.18%. Comparing base (058ce32) to head (093c0f8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6675      +/-   ##
==========================================
+ Coverage   17.80%   25.18%   +7.37%     
==========================================
  Files          32       33       +1     
  Lines        2819     2831      +12     
==========================================
+ Hits          502      713     +211     
+ Misses       2275     2071     -204     
- Partials       42       47       +5     
Flag Coverage Δ
inttests 9.57% <ø> (?)
unittests 17.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola force-pushed the upload_test_logs branch 2 times, most recently from c3dc317 to ccdca7d Compare September 3, 2024 18:03
@dereknola dereknola marked this pull request as ready for review September 3, 2024 19:01
@dereknola dereknola requested a review from a team as a code owner September 3, 2024 19:01
@dereknola dereknola merged commit 267a42a into rancher:master Sep 4, 2024
7 checks passed
@dereknola dereknola deleted the upload_test_logs branch September 9, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants