Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] Add ctr to shell completion #6733

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

vitorsavian
Copy link
Member

@vitorsavian vitorsavian commented Sep 5, 2024

Signed-off-by: Vitor Savian <[email protected]>
@vitorsavian vitorsavian marked this pull request as ready for review September 5, 2024 13:13
@vitorsavian vitorsavian requested a review from a team as a code owner September 5, 2024 13:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 25.11%. Comparing base (bc150d5) to head (bbcfa87).

Files with missing lines Patch % Lines
pkg/cli/cmds/completion.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28    #6733      +/-   ##
================================================
- Coverage         25.18%   25.11%   -0.08%     
================================================
  Files                33       33              
  Lines              2831     2839       +8     
================================================
  Hits                713      713              
- Misses             2071     2079       +8     
  Partials             47       47              
Flag Coverage Δ
inttests 9.54% <0.00%> (-0.03%) ⬇️
unittests 17.75% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit edbd601 into rancher:release-1.28 Sep 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants