Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 1.31] Remove sriov images from airgap tarball #6751

Conversation

thomasferrandiz
Copy link
Contributor

Backport: #6747
Issue: #6750

As discussed, it doesn't make sense anymore to keep them in the airgap tarball since we don't synchronize the sriov chart with an rke2 release.
@thomasferrandiz thomasferrandiz requested a review from a team as a code owner September 6, 2024 03:41
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.18%. Comparing base (d39b0b9) to head (3304bd0).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.31    #6751      +/-   ##
================================================
+ Coverage         17.80%   25.18%   +7.37%     
================================================
  Files                32       33       +1     
  Lines              2819     2831      +12     
================================================
+ Hits                502      713     +211     
+ Misses             2275     2071     -204     
- Partials             42       47       +5     
Flag Coverage Δ
inttests 9.57% <ø> (?)
unittests 17.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasferrandiz thomasferrandiz changed the title Remove sriov images from airgap tarball [release 1.31] Remove sriov images from airgap tarball Sep 6, 2024
@thomasferrandiz thomasferrandiz merged commit 93e47f1 into rancher:release-1.31 Sep 6, 2024
6 checks passed
@thomasferrandiz thomasferrandiz deleted the issue-6746_release-1.31 branch November 7, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants