Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trivy scanning to PR reports #6806

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Sep 11, 2024

Proposed Changes

Once this is merged, it allows user to comment /trivy on a PR to trigger a trivy report on the rke2-runtime and rke2 go.mod

Types of Changes

CI

Verification

Verified on dereknola#2 (note that was using the GHA public runners, I can't test if the custom runners work until we merge this PR into master)

Testing

N/A

Linked Issues

User-Facing Change


Further Comments

For now we are only reporting on the linux amd64 build of rke2-runtime. In the future, we can expand this to the windows and other images.

@dereknola dereknola requested a review from a team as a code owner September 11, 2024 20:09
Signed-off-by: Derek Nola <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.54%. Comparing base (a8abb0a) to head (a2acf4e).

❗ There is a different number of reports uploaded between BASE (a8abb0a) and HEAD (a2acf4e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a8abb0a) HEAD (a2acf4e)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #6806       +/-   ##
==========================================
- Coverage   25.11%   9.54%   -15.57%     
==========================================
  Files          33      33               
  Lines        2839    2839               
==========================================
- Hits          713     271      -442     
- Misses       2079    2545      +466     
+ Partials       47      23       -24     
Flag Coverage Δ
inttests 9.54% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit b91cab9 into rancher:master Sep 12, 2024
7 checks passed
dereknola added a commit to dereknola/rke2 that referenced this pull request Sep 17, 2024
* Add trivy GHA workflow for scanning rke2-runtime image

Signed-off-by: Derek Nola <[email protected]>

* Use customer runners

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/rke2 that referenced this pull request Sep 17, 2024
* Add trivy GHA workflow for scanning rke2-runtime image

Signed-off-by: Derek Nola <[email protected]>

* Use customer runners

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/rke2 that referenced this pull request Sep 17, 2024
* Add trivy GHA workflow for scanning rke2-runtime image

Signed-off-by: Derek Nola <[email protected]>

* Use customer runners

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/rke2 that referenced this pull request Sep 17, 2024
* Add trivy GHA workflow for scanning rke2-runtime image

Signed-off-by: Derek Nola <[email protected]>

* Use customer runners

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Sep 26, 2024
* Add trivy scanning to PR reports (#6806)

* Add trivy GHA workflow for scanning rke2-runtime image

* Add membership check

* Breakup trivy scan into isolated jobs

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Sep 26, 2024
* Add trivy scanning to PR reports (#6806)

* Add trivy GHA workflow for scanning rke2-runtime image

* Breakup trivy scan into isolated jobs

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Sep 26, 2024
* Add trivy scanning to PR reports (#6806)

* Add trivy GHA workflow for scanning rke2-runtime image

* Breakup trivy scan into isolated jobs

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Sep 26, 2024
* Add trivy scanning to PR reports (#6806)

* Add trivy GHA workflow for scanning rke2-runtime image

* Breakup trivy scan into isolated jobs

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola deleted the trivy_action branch October 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants