rke2-runtime signing and manifests #7089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Newberry <[email protected]>
brooksn
commented
Oct 21, 2024
| fi | ||
| ./scripts/setup-docker-builder | ||
|
|
||
| DOCKER_BUILDKIT=${DOCKER_BUILDKIT:-1} docker image build ${IID_FILE_FLAG} \ |
There was a problem hiding this comment.
The publish-image action calls the make target, and sets IID_FILE_FLAG for use by cosign.
dereknola
reviewed
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7089 +/- ##
=======================================
Coverage 16.62% 16.62%
=======================================
Files 32 32
Lines 3423 3423
=======================================
Hits 569 569
Misses 2812 2812
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Brooks Newberry <[email protected]>
dereknola
approved these changes
Oct 22, 2024
briandowns
approved these changes
Oct 22, 2024
brooksn
added a commit
to brooksn/rke2
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Brooks Newberry <[email protected]>
brooksn
added a commit
to brooksn/rke2
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Brooks Newberry <[email protected]>
brooksn
added a commit
to brooksn/rke2
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Brooks Newberry <[email protected]>
brooksn
added a commit
to brooksn/rke2
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Brooks Newberry <[email protected]>
brooksn
added a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Brooks Newberry <[email protected]>
brooksn
added a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Brooks Newberry <[email protected]>
brooksn
added a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Brooks Newberry <[email protected]>
brooksn
added a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Brooks Newberry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments