Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish release trivy scans as an artifact #7148

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Oct 28, 2024

Proposed Changes

  • Upload trivy report of scanned release images to GH as an action artifact. This enables us to download or share the report elsewhere.

Types of Changes

Verification

Running locally:

docker run --rm -v "$(pwd)/build:/build" -v "$(pwd):/workspace" \
         -w /workspace rancher/hardened-build-base:v1.22.8b2 \
         make scan-images

Afterwards a new file trivy-scan-report.txt is available to be uploaded.
I can't test the release process itself.

Testing

Linked Issues

#6643

User-Facing Change


Further Comments

The current base image used in the Dockerfile contains a old version of trivy (0.42). A new version of the base image has been published with trivy (0.56), but I didn't want to complicate this PR by bumping it.

@dereknola dereknola requested a review from a team as a code owner October 28, 2024 16:06
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.62%. Comparing base (c0e7e1e) to head (adff014).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7148   +/-   ##
=======================================
  Coverage   16.62%   16.62%           
=======================================
  Files          32       32           
  Lines        3423     3423           
=======================================
  Hits          569      569           
  Misses       2812     2812           
  Partials       42       42           
Flag Coverage Δ
unittests 16.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cwayne18 cwayne18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so very much for this

@dereknola dereknola merged commit 3af06a5 into rancher:master Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants