Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS and CA Certificate support for wins #111

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

rosskirkpat
Copy link
Contributor

add new functionality for fetching certificates from Rancher, external URL, and from a local file.

@rosskirkpat
Copy link
Contributor Author

rancher/rancher#37483

Copy link
Contributor

@phillipsj phillipsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please document this in the README.

pkg/tls/tls.go Outdated Show resolved Hide resolved
@rosskirkpat
Copy link
Contributor Author

README updated and implementation in csiproxy added. Re-requesting reviews now.

Copy link
Contributor

@luthermonson luthermonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your commits tho

@rosskirkpat rosskirkpat merged commit 5d8f86b into rancher:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows bug Something isn't working team/area4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants