-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump system agent, fix revive errors, update golangci-lint config file #199
Conversation
We will be releasing system-agent |
|
1d144e5
to
3a14eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
3a14eff
to
cc8e212
Compare
I've tested the system agent However, the latest version of the system agent has changed the While testing the new version of the system agent, and determining why the environment variable was not being passed, I stumbled on this old windows issue rancher/windows#181. This issue was not properly tested, and does not work as intended. This is likely one of the reasons that the strict tls verification environment variable is not being passed to wins, and why the wins binary does not upgrade alongside Rancher versions. |
Issue rancher/rancher#46219, rancher/rancher#46220
Summary
Several Kubernetes dependencies are outdated and contain CVEs. These dependencies are indirect and are used mostly by the embedded system agent. In order to use the most recent dependency versions, the system agent dependency should also be updated, as we do not know if there are any regressions or changes in behavior when combining an older version of the system agent with newer dependency versions.
Occurred changes and/or fixed issues
Bumped the system agent and the related k8s dependencies. We now use
1.27.x
for all Kubernetes dependencies, which is inline with the most recent system agent version0.3.7
.Recent versions of the system agent have introduced a concept of 'interlock files', which were designed to improve consistency when executing plans. Currently, there are no Windows specific plans which utilize these files, so the
applyinator.NewApplyinator
function signature intentionally omits that parameter.v0.3.7
of the system-agent changed the signature ofk8splan.Watch
, which now requires an additional boolean. Unfortunately, Rancher has not been properly updated to propagate an environment variable or other value to specify what the value of that boolean should be. Due to this, the value is currently set tofalse
to ensure there are no behavior changes.Additionally, the CI has been updated to accommodate the extra time required to lint the updated dependencies.
Technical notes summary
Areas or cases that should be tested
When a new version of wins is cut and vendored into Rancher, we should test all basic provisioning use cases.
Areas which could experience regressions
Screenshot/Video