Add .del() support
#13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only `b4a.copy()` was needed.
Also converted tests to use `b4a.toString(buf)` instead of `buf.toString()`.
No need for `buffer-alloc` when `b4a` supplies the ponyfill for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #12 so can be refactored if
b4asupport isn't approved.I've run some simple tests using this as a hypercore storage and things seems to be working.
A potential question is what to do when deleting creates blocks of all zeroes but there are non-zero blocks afterwards, aka do we just zero ranges in the middle of the storage or do we delete the blocks from indexedDB to save space? For now, this PR just zeros the range for simplicity. If deleting all zero blocks is added, I'd recommend adding a
sparseoption to the constructor likerandom-access-filehas.