Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading hash keys from file #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

d0vgan
Copy link

@d0vgan d0vgan commented Dec 10, 2020

Reading hash keys from file "SharpKeys.keys"

@d0vgan d0vgan force-pushed the feature/reading_hash_keys_from_file branch from 2d42505 to 45e8faf Compare February 15, 2022 10:19
@d0vgan d0vgan force-pushed the feature/reading_hash_keys_from_file branch from 038dc10 to c7afc65 Compare February 15, 2022 10:26
@enkelmedia
Copy link

enkelmedia commented Jan 27, 2023

This one would be great! This way someone can add custom mapps without having to recompile and release the application! =D

Edit:
I wrote that comment a little too early before understanding the potential impacts of an issue and the limitations of the built in windows-mappings.

No I think: Idea is quite dangerous. Lots of people will skew up their mappings and ask questions.

@randyrants
Copy link
Owner

...except that there have been no new scan codes added since before this PR was submitted and it introduces at least two new attack services for the app itself. I've left this one open for anyone that wants to compile with it on their own, but I've had no interest in bringing it into the baseline, especially since most people will start adding keys that cannot be remapped and possibly end up in a bad state. e.g. someone successfully remaps ALT-GR because the first two bytes are successfully remapped, but what else starts with those same two bytes? Especially if it takes out a key that is part of your password or PIN?

Yeah... not so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants