-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to modern python packaging #406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolutely fantastic @getzze! Thank you for implementing this. I'll definitely re-use this as a template in some of my other projects. One request to update the datasets path and then we should be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Thanks again, I'll run some final checks and merge later this week.
I just rebased. I saw that you don't run the tests on python 3.8 anymore, do you want me to bump the minimal python version in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #406 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 19 19
Lines 3359 3359
Branches 547 547
=======================================
Hits 3310 3310
Misses 26 26
Partials 23 23 ☔ View full report in Codecov by Sentry. |
Thank you!
I've disabled them because it led to a small rounding error for one particular unit test (logistic regression), most likely related to sklearn version differences. I didn't have time to investigate more, but all the other tests are working fine so I don't think there's a need to bump the minimal version to 3.8. |
Just FYI with this change, editable installations won't work the way you're used to. We experienced this issue with various MNE-Python-related projects. The solution was to switch from the See mne-tools/mne-python#12169 for details |
@hoechenberger thank you for the heads-up! Very good to know. Let me merge this PR now and feel free to create a new one to use the |
Using
setup.py
andsetup.cfg
is deprecated in favor of a singlepyproject.toml
file:https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html
This PR removes these two files and the
requirements*.txt
files and puts all the relevant information inpyproject.toml
.Also the
pingouin
subfolder is removed, the tests are moved to thetests
folder and the source to thesrc/pingouin
folder.The version number is uniquely defined in the
__init__.py
source file.