Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault for preferred_memory_capacity in Python 3.9+ #214

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Fix segfault for preferred_memory_capacity in Python 3.9+ #214

merged 1 commit into from
Feb 1, 2022

Conversation

gigony
Copy link
Contributor

@gigony gigony commented Feb 1, 2022

Implicit conversion from uint_32_t to py::int_ causes segmentation fault from Python 3.9+.

This patch fixes the issue by using the proper type.

Fixes #213

Signed-off-by: Gigon Bae [email protected]

@gigony gigony added the bug Something isn't working label Feb 1, 2022
@gigony gigony added this to the v22.02.00 milestone Feb 1, 2022
@gigony gigony requested a review from jakirkham February 1, 2022 00:20
@gigony gigony self-assigned this Feb 1, 2022
@gigony gigony requested a review from a team as a code owner February 1, 2022 00:20
@gigony gigony added the non-breaking Introduces a non-breaking change label Feb 1, 2022
@jjacobelli jjacobelli merged commit 9d70348 into rapidsai:branch-22.02 Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjacobelli jjacobelli jjacobelli approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees

@gigony gigony

Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
v22.02.00
Development

Successfully merging this pull request may close these issues.
3 participants
@gigony @jakirkham @jjacobelli