fix RawKernel bug for canny filter when quantiles are used #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expand canny quantile tests over additional input dtypes refactor test cases to remove use of unittest so parametrize can be used
grlee77
added
bug
|
rerun tests |
jakirkham
approved these changes
Jun 16, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
This PR incorporates the two bug fixes from skimage v0.19.3 (released on June 12th) that are relevant to cuCIM. - bug fix to ensure all color channel share the same histogram bins in `cucim.skimage.exposure.histogram` - clipping in warp functions should respect user-specified `cval` during clipping even if it is outside the original image range There was also a fix to Canny edge detection, but we had already resolved that issue in cuCIM. I did go ahead and add the new test case for it to #310. Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - https://github.com/jakirkham URL: #312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
cannythat was leading to failures intest_use_quantiles. It also expands that test case viapytest.parametrizeto cover additional dtypesThe changes to other test classes are merely refactoring to avoid use of
unittest.TestCaseso thatpytest.parametrizecan be used