Add disambiguation option to phase_cross_correlation (skimage 0.20 feature) #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use elementwise tuple operations instead of CuPy or NumPy array operations. This is much faster for these tiny arrays of length reference_image.ndim.
grlee77
added
breaking
Codecov ReportBase: 92.95% // Head: 92.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #486 +/- ##
================================================
- Coverage 92.95% 92.94% -0.01%
================================================
Files 130 130
Lines 9775 9805 +30
================================================
+ Hits 9086 9113 +27
- Misses 689 692 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR ports a couple of recent features merged upstream for scikit-image 0.20
lab2rgbandrgb2labphase_cross_correlation(default of False matches the old behavior)There is also one change that is technically breaking in that the shift is now always returned as a tuple of floats rather than as a
cupy.ndarrayof sizerefernce_image.ndim. I think this is preferable and working with small coordinate tuples rather than using array operations allows avoiding kernel launch overheads. Upstream scikit-image is a bit inconsistent in that it returns a tuple whendisambiguateis True, but a numpy.ndarray otherwise. It should probably be changed to return a tuple in all cases.