Sync cuCIM API with scikit-image 0.21 #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename deprecated utility to deprecate_func style: list->tuple in delta_e.py xyz_tristimulus_values should be public
add test_adapthist_incorrect_kernel_size test case
add mask test
remove deprecated iterations kwarg from richardson_lucy
make accessing Delaunay simplices robust across SciPy versions
grlee77
added
breaking
seems to avoid bug with larger signed integer ranges and CUDA 12.x
|
Thanks Greg! 🙏 Does this depend on scikit-image 0.21.0 packages ( conda-forge/scikit-image-feedstock#103 )? Edit: Rerunning CI now that those packages are out |
Closed
No, it should still work on older scikit-image as currently pinned |
|
/merge |
|
Thank you both! 🙏 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Follow up to PR ( #573 ) This allows `scikit-image` version `0.21.0` to be installed alongside `cucim`. Authors: - https://github.com/jakirkham Approvers: - Ray Douglass (https://github.com/raydouglass) - Gregory Lee (https://github.com/grlee77) URL: #580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR ports several recent changes implemented upstream in scikit-image 0.21rc0. Some are just minor refactoring or documentation fixes, but I have commented on the more significant changes below so we can reuse that for the release note.
If preferred, I can split the items below into separate small PRs.
API Changes / Deprecations
The
random_stateargument ofmedial_axisandunsupervised_wieneris now deprecated and will be removed in the future. The new argument name,seed, should be used instead.The formerly private function
_invariant_denoisehas been renameddenoise_invariantand is now part of the publiccucim.skimage.restorationAPI.The existing function
cucim.skimage.color.get_xyz_coordshas been renamedcucim.skimage.color.xyz_tristimulus_values. The former function name is deprecated and will be removed in the future.Enhancements
A new
return_mappingoption was added tojoin_segmentations. This provides an additional output with a mapping between the labels in the joined segmentation and the original ones.Added support for y-axis shear to the 2D AffineTransform
Backwards Incompatible Changes
chan_vesemay result in different output from previous versions.Bug Fixes
Fixed bug in energy calculation in Chan-Vese
Fixed a bug in 2D shear calculations for
AffineTransform