Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linting tool versions and replace isort with ruff #622

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Update linting tool versions and replace isort with ruff #622

merged 5 commits into from
Oct 31, 2023

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Oct 30, 2023

This PR is a small follow-up to #616 (regarding comments by @bdice)

It also introduces a .git-blame-ignore-revs to ignore all of the formatting changes introduced in !616 from git blame views

@grlee77
update codespell to the latest version
fe70410 
fix a couple newly identified spelling errors
@grlee77
update black to latest version
264d6cb
@grlee77
bump ruff to latest revision
4813faf
@grlee77
update ruff and replace isort with ruff
2d00b31 
update ruff to run safe fixes automatically in the pre-commit hook
@grlee77
introduce .git-blame-ignore-revs
eba00c7 
add the commit corresponding to prior global application of linters
@grlee77 grlee77 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change maintenance labels Oct 30, 2023
@grlee77 grlee77 added this to the v23.12.00 milestone Oct 30, 2023
@grlee77 grlee77 self-assigned this Oct 30, 2023
@grlee77 grlee77 requested a review from a team as a code owner October 30, 2023 15:30
@jakirkham jakirkham mentioned this pull request Oct 30, 2023
Merged
bdice
bdice approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is what I had in mind in the previous PR. 👍

gigony
gigony approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @grlee77 .
Looks good to me!

For the code changes by lint here, do we need to add another commit into .git-blame-ignore-revs file after this PR is merged?

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a680cf6 into rapidsai:branch-23.12 Oct 31, 2023
30 checks passed
@jakirkham
Copy link
Member

Thanks Greg for the PR and everyone for the reviews! 🙏

@jakirkham jakirkham mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@jakirkham jakirkham jakirkham approved these changes

@gigony gigony gigony approved these changes

Assignees

@grlee77 grlee77

Labels
improvement Improves an existing functionality maintenance non-breaking Introduces a non-breaking change
Projects
cucim
Status: Done
Milestone
v23.12.00
Development

Successfully merging this pull request may close these issues.
4 participants
@grlee77 @jakirkham @gigony @bdice