Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI (pt. 2) #680

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Fix CI (pt. 2) #680

merged 5 commits into from
Jan 24, 2024

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jan 24, 2024

Fixes #664

  • Pin RAPIDS packages to intended version (this helped find the openslide / openslide-python issue)
  • Validate wheels have the expected name (no none in them like with pure wheels)

@jakirkham jakirkham added bug Something isn't working non-breaking Introduces a non-breaking change labels Jan 24, 2024
@jakirkham jakirkham marked this pull request as ready for review January 24, 2024 17:39
@jakirkham jakirkham requested a review from a team as a code owner January 24, 2024 17:39
Now that `openslide-python` has been rebuilt with `openslide` `4`, this
pin is no longer needed.
@@ -71,7 +71,7 @@ requirements:
- jbig
- libwebp-base
- nvtx-c >=3.1.0
- openslide 3
- openslide
Copy link
Member Author

@jakirkham jakirkham Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed as openslide-python was rebuilt with 4 ( conda-forge/openslide-python-feedstock#17 )

Going forward openslide will have migrations ( conda-forge/conda-forge-pinning-feedstock#5415 ), which should hopefully cutdown on the churn here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me

@jakirkham
Copy link
Member Author

Thanks all! 🙏

@jakirkham
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit bf5a6f7 into rapidsai:branch-24.02 Jan 24, 2024
39 checks passed
This was referenced Jan 24, 2024
@jakirkham jakirkham deleted the fix_ci_2 branch January 24, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate wheel on CI
3 participants