Refactor CUDA libraries in dependencies.yaml #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bdice
added
feature request
bdice
commented
Feb 9, 2024
| - matrix: | ||
| cuda: "12.*" | ||
| packages: | ||
| - cuda-nvcc | ||
| - libcufile-dev |
There was a problem hiding this comment.
This matrix could be included on aarch64, which would pull in libcufile-dev. That isn't what we want. Thankfully we never ran into this in practice, to my knowledge.
jakirkham
reviewed
Feb 9, 2024
AyodeAwe
approved these changes
Feb 9, 2024
jakirkham
approved these changes
Feb 9, 2024
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #672. This fixes an issue where libcufile-dev could be included in aarch64 environments (this path was never called in CI so it wasn't a huge problem).
I also fixed some duplication in dependencies.yaml. The CUDA compilers (for 11 and 12) are now included in the
builddependency list, and all CUDA libraries are included in thecudadependency list. As before, the CUDA version is constrained by thecuda_versiondependency list. This is more aligned with how cudf's dependency list is structured.