-
Notifications
You must be signed in to change notification settings - Fork 908
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add cudf::strings::contains_multiple (#16900)
Add new `cudf::strings::contains_multiple` API to search multiple targets within a strings column. Output is a table where the number of columns is the number of targets and each row is a boolean indicating that target was found at the row or not. This PR is to help in collaboration with #16641 Authors: - David Wendt (https://github.com/davidwendt) - GALI PREM SAGAR (https://github.com/galipremsagar) - Chong Gao (https://github.com/res-life) - Bradley Dice (https://github.com/bdice) Approvers: - Chong Gao (https://github.com/res-life) - Yunsong Wang (https://github.com/PointKernel) - MithunR (https://github.com/mythrocks) - Tianyu Liu (https://github.com/kingcrimsontianyu) - Bradley Dice (https://github.com/bdice) URL: #16900
- Loading branch information
1 parent
7682edb
commit 796de4b
Showing
9 changed files
with
592 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
/* | ||
* Copyright (c) 2024, NVIDIA CORPORATION. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#include <benchmarks/common/generate_input.hpp> | ||
#include <benchmarks/fixture/benchmark_fixture.hpp> | ||
|
||
#include <cudf_test/column_wrapper.hpp> | ||
|
||
#include <cudf/strings/find.hpp> | ||
#include <cudf/strings/find_multiple.hpp> | ||
#include <cudf/strings/strings_column_view.hpp> | ||
#include <cudf/utilities/default_stream.hpp> | ||
|
||
#include <nvbench/nvbench.cuh> | ||
|
||
static void bench_find_string(nvbench::state& state) | ||
{ | ||
auto const n_rows = static_cast<cudf::size_type>(state.get_int64("num_rows")); | ||
auto const row_width = static_cast<cudf::size_type>(state.get_int64("row_width")); | ||
auto const hit_rate = static_cast<cudf::size_type>(state.get_int64("hit_rate")); | ||
auto const target_count = static_cast<cudf::size_type>(state.get_int64("targets")); | ||
auto const api = state.get_string("api"); | ||
|
||
auto const stream = cudf::get_default_stream(); | ||
auto const col = create_string_column(n_rows, row_width, hit_rate); | ||
auto const input = cudf::strings_column_view(col->view()); | ||
|
||
// Note that these all match the first row of the raw_data in create_string_column. | ||
// This is so the hit_rate can properly accounted for. | ||
std::vector<std::string> const target_data( | ||
{" abc", "W43", "0987 5W43", "123 abc", "23 abc", "3 abc", "7 5W43", "87 5W43", "987 5W43"}); | ||
auto h_targets = std::vector<std::string>{}; | ||
for (cudf::size_type i = 0; i < target_count; i++) { | ||
h_targets.emplace_back(target_data[i % target_data.size()]); | ||
} | ||
cudf::test::strings_column_wrapper targets(h_targets.begin(), h_targets.end()); | ||
|
||
state.set_cuda_stream(nvbench::make_cuda_stream_view(stream.value())); | ||
auto const chars_size = input.chars_size(stream); | ||
state.add_global_memory_reads<nvbench::int8_t>(chars_size); | ||
if (api == "find") { | ||
state.add_global_memory_writes<nvbench::int32_t>(input.size()); | ||
} else { | ||
state.add_global_memory_writes<nvbench::int8_t>(input.size()); | ||
} | ||
|
||
if (api == "find") { | ||
state.exec(nvbench::exec_tag::sync, [&](nvbench::launch& launch) { | ||
cudf::strings::find_multiple(input, cudf::strings_column_view(targets)); | ||
}); | ||
} else if (api == "contains") { | ||
state.exec(nvbench::exec_tag::sync, [&](nvbench::launch& launch) { | ||
cudf::strings::contains_multiple(input, cudf::strings_column_view(targets)); | ||
}); | ||
} | ||
} | ||
|
||
NVBENCH_BENCH(bench_find_string) | ||
.set_name("find_multiple") | ||
.add_string_axis("api", {"find", "contains"}) | ||
.add_int64_axis("targets", {10, 20, 40}) | ||
.add_int64_axis("row_width", {32, 64, 128, 256}) | ||
.add_int64_axis("num_rows", {32768, 262144, 2097152}) | ||
.add_int64_axis("hit_rate", {20, 80}); // percentage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.