Skip to content

Commit

Permalink
Move detail header floating_conversion.hpp to detail subdirectory (#1…
Browse files Browse the repository at this point in the history
…7209)

Moves the 'cudf/fixed_point/floating_conversion.hpp' to `cudf/fixed_point/detail/` subdirectory since it only contains declarations and definition in the `detail` namespace.
It had previously been its own module. https://docs.rapids.ai/api/libcudf/stable/modules.html

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Shruti Shivakumar (https://github.com/shrshi)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Nghia Truong (https://github.com/ttnghia)

URL: #17209
  • Loading branch information
davidwendt authored Oct 31, 2024
1 parent 3db6a0e commit f99ef41
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@
#include <cstring>

namespace CUDF_EXPORT numeric {

/**
* @addtogroup floating_conversion
* @{
* @file
* @brief fixed_point <--> floating-point conversion functions.
*/

namespace detail {

/**
Expand Down Expand Up @@ -1141,6 +1133,4 @@ CUDF_HOST_DEVICE inline FloatingType convert_integral_to_floating(Rep const& val
}

} // namespace detail

/** @} */ // end of group
} // namespace CUDF_EXPORT numeric
2 changes: 1 addition & 1 deletion cpp/include/cudf/unary.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

#pragma once

#include <cudf/fixed_point/detail/floating_conversion.hpp>
#include <cudf/fixed_point/fixed_point.hpp>
#include <cudf/fixed_point/floating_conversion.hpp>
#include <cudf/types.hpp>
#include <cudf/utilities/default_stream.hpp>
#include <cudf/utilities/export.hpp>
Expand Down

0 comments on commit f99ef41

Please sign in to comment.