You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
While reimplementing Spark hashing in #11292, I noticed that HASH_SERIAL_MURMUR3 does not appear to be used except in tests. It is not exposed in Python. While it is exposed in the JNI bindings, it is not used by spark-rapids. I discussed this with @rwlee and it seems that this feature was added only for parallel design with the Spark serial hash implementation in #6781. We may not need to keep this feature in the code base.
Describe the solution you'd like
After #11292 is complete, the serial_murmur_hash3_32 template function used for HASH_SERIAL_MURMUR3 won't be needed by HASH_SPARK_MURMUR3. Then evaluate deprecation/removal of the HASH_SERIAL_MURMUR3 feature.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
While reimplementing Spark hashing in #11292, I noticed that
HASH_SERIAL_MURMUR3
does not appear to be used except in tests. It is not exposed in Python. While it is exposed in the JNI bindings, it is not used by spark-rapids. I discussed this with @rwlee and it seems that this feature was added only for parallel design with the Spark serial hash implementation in #6781. We may not need to keep this feature in the code base.Describe the solution you'd like
After #11292 is complete, the
serial_murmur_hash3_32
template function used forHASH_SERIAL_MURMUR3
won't be needed byHASH_SPARK_MURMUR3
. Then evaluate deprecation/removal of theHASH_SERIAL_MURMUR3
feature.The text was updated successfully, but these errors were encountered: