Update developer guide to recommend no default stream parameter. #10136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
reviewed
Jan 26, 2022
ttnghia
reviewed
Jan 26, 2022
bdice
commented
Jan 26, 2022
Co-authored-by: Nghia Truong <[email protected]>
ttnghia
approved these changes
Jan 26, 2022
davidwendt
reviewed
Jan 26, 2022
mythrocks
approved these changes
Jan 28, 2022
davidwendt
reviewed
Jan 28, 2022
davidwendt
reviewed
Jan 28, 2022
davidwendt
reviewed
Jan 28, 2022
Co-authored-by: David Wendt <[email protected]>
davidwendt
approved these changes
Jan 28, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the developer guide to address #9854. With this change, any new or refactored detail APIs should have no default stream parameter. We may resolve that issue or perhaps leave it open until a majority of code has no default stream.