-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two-table comparators with strong index types #10730
Merged
Merged
Changes from 34 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
50b8891
Add strong index type.
bdice b9ed4d7
Revert changes to non-experimental row operators.
bdice d67f17e
Use enum for strongly typed index.
bdice 464ed2b
Add two table comparator and adapter.
bdice b26b318
Add friends. :)
bdice 1fd199d
Apply two-table comparator to search algorithms.
bdice 18bd9f0
Move shared lhs/rhs logic into launch_search.
bdice b5b8b39
Improve comments, remove old code.
bdice 4060b4f
Merge remote-tracking branch 'upstream/branch-22.06' into strong-inde…
bdice 73c4b27
Move strong typing code into cudf::experimental::row::lexicographic.
bdice 9cdbe27
Merge remote-tracking branch 'upstream/branch-22.06' into strong-inde…
bdice c8a38fe
Improve comment.
bdice 8b5ef34
Fix docstrings.
bdice 77f85b4
Enable weak ordering machinery (weak_ordering_comparator_impl) to wra…
bdice 529e944
Remove template template parameters.
bdice fb0e192
Use references.
bdice 56d99ba
Use Ts const...
bdice c5998b7
Move strong typing to cudf::experimental::row.
bdice b78d978
Use constexpr.
bdice 3aea8d4
Use custom iterator class.
bdice bbaf360
Use __device__ only.
bdice 4a1d7aa
Add comment.
bdice 09c5661
Use symmetry of comparator (now possible with weak ordering) to avoid…
bdice 290323f
Add constexpr to two_table_device_row_comparator_adapter.
bdice 4c69edd
Remove forward (always accepts lvalues).
bdice fbd5b90
Indicate reversed signature.
bdice 3db6484
Move constructor to implementation, add shape compatibility check.
bdice 3e81b53
Improve docstrings.
bdice 1834095
Use thrust::iterator_facade.
bdice ff26024
Use const for struct members.
bdice f779bff
Slim down the strong index layer by using a templated struct.
bdice 157abbc
Simplify construction.
bdice a2ac19d
Use size_type const where possible.
bdice 75249e8
Require weakly or strongly typed values for lhs_index and rhs_index.
bdice bed1162
Unconstrain template typenames.
bdice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdice I realize that I am late to the party here, but this struct has zero docs. A new reader of the code won't have any idea why this struct exists since the purpose is not conveyed by its implementation, but rather by its existence alone. Could you make a PR with some brief documentation (or maybe just stick that into one of the downstream PRs that either you or @ttnghia is working on)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. I can create a standalone PR for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#10888