Cleanup iterator.cuh and add fixed point support for scalar_optional_accessor
#10999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
3 - Ready for Review
This comment was marked as off-topic.
This comment was marked as off-topic.
karthikeyann
requested changes
May 28, 2022
There was a problem hiding this comment.
Why return type const qualifier is considered redundant ?
return type is marked const so that the user does not try to modify the dereferenced value.
Look at https://godbolt.org/z/n5MjTxqrf
Ah I see the purpose: Typically we don't need that, but here we have the iterators naming |
|
rerun tests |
bdice
reviewed
May 31, 2022
bdice
approved these changes
May 31, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
This extends the `lists::contains` API to support nested types (lists + structs) with arbitrarily nested levels. As such, `lists::contains` will work with literally any type of input data. In addition, the related implementation has been significantly refactored to facilitate adding new implementation. Closes #8958. Depends on: * #10730 * #10883 * #10999 * #11019 * #11037 Authors: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) Approvers: - MithunR (https://github.com/mythrocks) - Bradley Dice (https://github.com/bdice) URL: #10548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
iterator.cuh, enforcingconstqualifier for accessors'operator().operator()functions, as they seem trivial: the struct iterators already state clearly their purpose.operator()functions__device__callable only: there is no need to call them (and they are never called) from host code.template <bool safe = false>formake_validity_iterator(scalar const&)overload, to make it having identical signature as themake_validity_iterator(column_device_view const&)overload.scalar_optional_accessor.This unblocks nested types support in
lists::contains(#10548), which needs fixed point support forscalar_optional_accessor.