[REVIEW] Defer loading of custom.js
#11465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2022
ajschmidt8
approved these changes
Aug 4, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11465 +/- ##
=============================================
Coverage 86.47% 86.47%
=============================================
Files 144 144
Lines 22856 22856
=============================================
Hits 19765 19765
Misses 3091 3091 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rapids-bot bot
pushed a commit
to rapidsai/kvikio
that referenced
this pull request
Aug 4, 2022
This PR switches the loading of `custom.js` to `defer` because we will need the entire page to be loading until the methods in this script can even execute correctly. xref: rapidsai/cudf#11465 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #114
rapids-bot bot
pushed a commit
to rapidsai/cucim
that referenced
this pull request
Aug 4, 2022
This PR switches the loading of `custom.js` to `defer` because we will need the entire page to be loading until the methods in this script can even execute correctly. xref: rapidsai/cudf#11465 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #383
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Aug 4, 2022
This PR switches the loading of custom.js to defer because we will need the entire page to be loading until the methods in this script can even execute correctly. xref: rapidsai/cudf#11465 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - H. Thomson Comer (https://github.com/thomcom) URL: #631
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Aug 4, 2022
This PR switches the loading of `custom.js` to defer because we will need the entire page to be loading until the methods in this script can even execute correctly. xref: rapidsai/cudf#11465 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Rick Ratzel (https://github.com/rlratzel) URL: #2506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the loading of
custom.jstodeferbecause we will need the entire page to be loading until the methods in this script can even execute correctly.Checklist