-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SparkMurmurHash3_32 functor. #11489
Merged
rapids-bot
merged 2 commits into
rapidsai:branch-22.10
from
bdice:move-spark-murmurhash-functor
Aug 9, 2022
Merged
Move SparkMurmurHash3_32 functor. #11489
rapids-bot
merged 2 commits into
rapidsai:branch-22.10
from
bdice:move-spark-murmurhash-functor
Aug 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Aug 8, 2022
rerun tests |
ttnghia
approved these changes
Aug 8, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11489 +/- ##
===============================================
Coverage ? 86.47%
===============================================
Files ? 144
Lines ? 22852
Branches ? 0
===============================================
Hits ? 19761
Misses ? 3091
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rwlee
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the
SparkMurmurHash3_32
functor fromhash_functions.cuh
tospark_murmur_hash.cu
, the only place where it is used. This is a pure move, with one small exception to avoid compiler warnings about unused members of the hash functor template instantiations for nested types. I refactored the class template to disallow nested types for the hash functor and removed those specializations usingCUDF_UNREACHABLE
, rather than allowing type dispatching to create template instantiations that have no defined use. (Nested types are being handled by the custom device row hasher inspark_murmur_hash.cu
, and require some state information that cannot be easily carried in the functor itself.) I am planning to do further refactoring later, but wanted to separate this "pure move" as much as possible.Part of #10081.
Checklist