Fix sort gtests coded in namespace cudf::test #12237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12237 +/- ##
===============================================
Coverage ? 88.26%
===============================================
Files ? 137
Lines ? 22586
Branches ? 0
===============================================
Hits ? 19935
Misses ? 2651
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davidwendt
added
3 - Ready for Review
nvdbaranec
reviewed
Nov 28, 2022
This helps with removing the default for the stream parameter. |
nvdbaranec
approved these changes
Nov 28, 2022
vuule
approved these changes
Nov 29, 2022
ttnghia
approved these changes
Nov 29, 2022
|
@gpucibot merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
…ns (#12254) Removes the default parameter declarations from `cudf::detail::sort`, `cudf::detail::sorted_order`, `cudf::detail::sort_by_key`, `cudf::detail::stable_sorted_order`, and `cudf::detail::stable_sort_by_key` as well as `cudf::detail::quantile`, `cudf::detail::quantiles` and `cudf::detail::percentile_approx` Reference comment: #12237 (comment) Also fixes incorrect stream parameter passed within a `quantiles.cu` detail function. No function has been added, modified, or changed. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Mark Harris (https://github.com/harrism) - Nghia Truong (https://github.com/ttnghia) - Yunsong Wang (https://github.com/PointKernel) URL: #12254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes sort gtests source files coded in namespace cudf::test
The segmented_sort_tests.cpp also included calls to detail functions which were unnecessary. These were changed to call the external API instead. This also allowed removing the default parameters from the segmented-sort detail functions.
No function or test has changed just the source code reworked per namespaces.
Reference #11734
Checklist