Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log messages about kvikIO compatibility mode #13363

Merged
merged 4 commits into from
May 23, 2023
Merged

Add log messages about kvikIO compatibility mode #13363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18b0b66
log kvikIO compat mode
vuule May 16, 2023
5e050c6
Merge branch 'branch-23.06' into fea-kvikio-compat-log
vuule May 16, 2023
c2c7375
Merge branch 'branch-23.06' of https://github.com/rapidsai/cudf into …
vuule May 22, 2023
a151357
Merge branch 'fea-kvikio-compat-log' of https://github.com/vuule/cudf…
vuule May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cpp/src/io/utilities/data_sink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ class file_sink : public data_sink {

if (detail::cufile_integration::is_kvikio_enabled()) {
_kvikio_file = kvikio::FileHandle(filepath, "w");
CUDF_LOG_INFO("Writing a file using kvikIO, with compatibility mode {}.",
_kvikio_file.is_compat_mode_on() ? "on" : "off");
Comment on lines +41 to +42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also log for the else branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to log anything in the else branch because it calls make_cufile_output, which includes the logging for that path (whether GDS was used or not).
Same goes for the other file, just with make_cufile_input.

} else {
_cufile_out = detail::make_cufile_output(filepath);
}
Expand Down
2 changes: 2 additions & 0 deletions cpp/src/io/utilities/datasource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ class file_source : public datasource {
{
if (detail::cufile_integration::is_kvikio_enabled()) {
_kvikio_file = kvikio::FileHandle(filepath);
CUDF_LOG_INFO("Reading a file using kvikIO, with compatibility mode {}.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly.

_kvikio_file.is_compat_mode_on() ? "on" : "off");
} else {
_cufile_in = detail::make_cufile_input(filepath);
}
Expand Down