Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward-merge branch-23.06 to branch-23.08 #13420

Merged
merged 1 commit into from
May 23, 2023
Merged

Forward-merge branch-23.06 to branch-23.08 #13420

merged 1 commit into from
May 23, 2023

Commits on May 23, 2023

  1. cuDF numba cuda 12 updates (#13337) 

    Summary of changes:

- Removed some old code that is only used for `numba<0.54` which hasn't been supported for a while now.
- Removed some old code that is only used when `cubinlinker` is not present, which is has been a hard requirement for a while now as well. 
- Created a file `_numba.py` and moved into this file all of the machinery used to configure numba upon cuDF import. This includes functions for determining which toolkit version was used to build the PTX file our UDFs rely on as well as the functions for potentially putting numba into MVC mode if necessary.
- Created a file `_ptxcompiler.py` which vendors the driver/runtime version checking machinery from ptxcompiler in case we're in a cuda 12 environment that doesn't have it
- Changed the code to issue a warning in cuda 12+ MVC situations that the library will likely not work
- The version of the toolkit used to determine if MVC is required is now determined from the `cc=60` PTX file which is [always built](https://github.com/rapidsai/cudf/blob/branch-23.06/python/cudf/udf_cpp/CMakeLists.txt#L85-L87). This is to avoid needing to query the device compute capability through numba's `cuda` module. This needs to be avoided during numba's setup because if `numba.cuda` is imported before numba's config is modified, the config options will have no effect. 

Closes #13351
Closes #13339

Authors:
  - https://github.com/brandon-b-miller

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Bradley Dice (https://github.com/bdice)
  - Graham Markall (https://github.com/gmarkall)
  - Ashwin Srinath (https://github.com/shwina)

URL: #13337
    @brandon-b-miller
    brandon-b-miller authored May 23, 2023
    Configuration menu
    Copy the full SHA
    12acf92 View commit details
    Browse the repository at this point in the history