Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the hashing detail default allocator #14827

Closed

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    2cdd7f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5716052 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6b681b2 View commit details
    Browse the repository at this point in the history
  4. Revert clangd changes

    PointKernel committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    5e34df3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1d33570 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dcb641e View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    3ffc505 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Simplify ColumnAccessor methods; avoid unnecessary validations (rapid…

    …sai#14758)
    
    For methods that essentially do
    
    ```python
    def select_by_foo(self, ...):
        ...
        return self.__class__(data={subset of self._data})
    ```
    
    The `return` would perform validation on the returned subset of column, but I think that's unnecessary since that was done during initialization
    
    Additionally
    * Removed `_create_unsafe` in favor of a `verify=True|False` keyword in the constructor
    * `_column_length` == `nrows` so removed `_column_length`
    * Renamed `_compare_keys` to `_keys_equal`
    * Remove seldom used/unnecessary methods
    
    Authors:
      - Matthew Roeschke (https://github.com/mroeschke)
    
    Approvers:
      - Vyas Ramasubramani (https://github.com/vyasr)
    
    URL: rapidsai#14758
    mroeschke authored and PointKernel committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d7bcda9 View commit details
    Browse the repository at this point in the history
  2. Use rapids_cuda_set_runtime to determine cuda runtime usage by targ…

    …et (rapidsai#14833)
    
    This PR uses rapids-cmake to handle per-target CMake linking to cudart.
    
    Replaces rapidsai#13543 and rapidsai#11641.
    
    Authors:
      - Vyas Ramasubramani (https://github.com/vyasr)
    
    Approvers:
      - Mark Harris (https://github.com/harrism)
      - Robert Maynard (https://github.com/robertmaynard)
    
    URL: rapidsai#14833
    vyasr authored and PointKernel committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    fb4ac33 View commit details
    Browse the repository at this point in the history
  3. Fix calls to deprecated strings factory API in examples. (rapidsai#14838

    )
    
    Follow-up PR to rapidsai#14771.
    
    I noticed the strings example code still had a deprecated function call:
    
    ```
    -- Build files have been written to: /opt/conda/conda-bld/work/cpp/examples/strings/build
    [1/8] Building CXX object CMakeFiles/libcudf_apis.dir/libcudf_apis.cpp.o
    [2/8] Linking CXX executable libcudf_apis
    [3/8] Building CUDA object CMakeFiles/custom_prealloc.dir/custom_prealloc.cu.o
    [4/8] Building CUDA object CMakeFiles/custom_with_malloc.dir/custom_with_malloc.cu.o
    [5/8] Linking CUDA executable custom_prealloc
    [6/8] Linking CUDA executable custom_with_malloc
    [7/8] Building CUDA object CMakeFiles/custom_optimized.dir/custom_optimized.cu.o
    /opt/conda/conda-bld/work/cpp/examples/strings/custom_optimized.cu: In function 'std::unique_ptr<cudf::column> redact_strings(const cudf::column_view&, const cudf::column_view&)':
    /opt/conda/conda-bld/work/cpp/examples/strings/custom_optimized.cu:158:40: warning: 'std::unique_ptr<cudf::column> cudf::make_strings_column(cudf::size_type, rmm::device_uvector<int>&&, rmm::device_uvector<char>&&, rmm::device_buffer&&, cudf::size_type)' is deprecated [-Wdeprecated-declarations]
      158 |   auto result =
          |               ~                        ^                                                          
    /opt/conda/conda-bld/work/cpp/include/cudf/column/column_factories.hpp:510:42: note: declared here
      510 | [[deprecated]] std::unique_ptr<column> make_strings_column(size_type num_strings,
          |                                          ^~~~~~~~~~~~~~~~~~~
    [8/8] Linking CUDA executable custom_optimized
    ```
    
    Authors:
      - Bradley Dice (https://github.com/bdice)
    
    Approvers:
      - David Wendt (https://github.com/davidwendt)
      - Vyas Ramasubramani (https://github.com/vyasr)
      - Mark Harris (https://github.com/harrism)
    
    URL: rapidsai#14838
    bdice authored and PointKernel committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    326edab View commit details
    Browse the repository at this point in the history
  4. Remove get_mem_info functions from custom memory resources (rapidsai#…

    …14832)
    
    Part of rapidsai/rmm#1388. This removes now-optional and soon-to-be deprecated functions from cuDF's custom device_memory_resource implementations:
     * `supports_get_mem_info()`
     * `do_get_mem_info()`
    
    Authors:
      - Mark Harris (https://github.com/harrism)
    
    Approvers:
      - Jason Lowe (https://github.com/jlowe)
      - Nghia Truong (https://github.com/ttnghia)
      - Vukasin Milovanovic (https://github.com/vuule)
    
    URL: rapidsai#14832
    harrism authored and PointKernel committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    914159b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bc130eb View commit details
    Browse the repository at this point in the history
  6. JSON single quote normalization API (rapidsai#14729)

    The goal of this PR is to address [10004](rapidsai#10004) by supporting parsing of JSON files containing single quotes for field/value strings. This is a follow-up work to the POC [PR 14545](rapidsai#14545)
    
    Authors:
      - Shruti Shivakumar (https://github.com/shrshi)
    
    Approvers:
      - Andy Grove (https://github.com/andygrove)
      - Vyas Ramasubramani (https://github.com/vyasr)
      - Vukasin Milovanovic (https://github.com/vuule)
      - Elias Stehle (https://github.com/elstehle)
      - Robert (Bobby) Evans (https://github.com/revans2)
    
    URL: rapidsai#14729
    shrshi authored and PointKernel committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2da3b54 View commit details
    Browse the repository at this point in the history
  7. Update conda-cpp-post-build-checks to branch-24.04. (rapidsai#14854)

    Fixes some merge issues with outdated versions from rapidsai#14768. I also made a minor tweak to `update-version.sh` that double-quotes some outputs to make pre-commit happier.
    
    Authors:
      - Bradley Dice (https://github.com/bdice)
    
    Approvers:
      - Jake Awe (https://github.com/AyodeAwe)
    
    URL: rapidsai#14854
    bdice authored and PointKernel committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a0489b5 View commit details
    Browse the repository at this point in the history
  8. Add row index and stripe size options to Python ORC chunked writer (r…

    …apidsai#14785)
    
    Adds the APIs that control the stripe/row group size when using the chunked writer. This functions are already present in to_orc (non-chunked version of the same API).
    
    Adding this options to facilitate smaller unit tests.
    
    Authors:
      - Vukasin Milovanovic (https://github.com/vuule)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
    
    URL: rapidsai#14785
    vuule authored and PointKernel committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    184bf5e View commit details
    Browse the repository at this point in the history
  9. Use detail cuco_allocator

    PointKernel committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    cb3e0b3 View commit details
    Browse the repository at this point in the history