Implement rolling in pylibcudf #14982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
feature request
mroeschke
reviewed
Feb 7, 2024
| @classmethod | ||
| def from_udf(cls, op, *args, **kwargs): | ||
| # Handling UDF type | ||
| nb_type = numpy_support.from_dtype(kwargs['dtype']) |
There was a problem hiding this comment.
Nit: Would be since if dtype was explicitly in the signature.
There was a problem hiding this comment.
Agreed. There's a lot of rewriting of the Cython layer that we should do once pylibcudf is completed.
mroeschke
approved these changes
Feb 7, 2024
|
/merge |
1 similar comment
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #13921
Checklist