Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate filling operations to pylibcudf #15225

Merged
merged 12 commits into from
Mar 7, 2024
Merged

Migrate filling operations to pylibcudf #15225

merged 12 commits into from
Mar 7, 2024

Conversation

brandon-b-miller
Copy link
Contributor

@brandon-b-miller brandon-b-miller commented Mar 4, 2024 •
edited
Loading

This PR migrates the filling operations in cuDF Python to pylibcudf.

@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Mar 4, 2024
@brandon-b-miller brandon-b-miller marked this pull request as ready for review March 5, 2024 20:48
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner March 5, 2024 20:48
@brandon-b-miller brandon-b-miller added feature request New feature or request non-breaking Non-breaking change labels Mar 5, 2024
vyasr
vyasr requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Mostly doc change requests along with a bit of extra typing.

python/cudf/cudf/_lib/pylibcudf/filling.pxd Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Outdated Show resolved Hide resolved
vyasr
vyasr reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things. I'll just apply the changes, then I think this is good to go!

python/cudf/cudf/_lib/pylibcudf/filling.pxd Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/pylibcudf/filling.pyx Show resolved Hide resolved
@brandon-b-miller
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 352d686 into rapidsai:branch-24.04 Mar 7, 2024
77 of 78 checks passed
@vyasr vyasr added the pylibcudf Issues specific to the pylibcudf package label May 28, 2024
@lithomas1 lithomas1 mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
pylibcudf
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandon-b-miller @vyasr