Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DELTA_BYTE_ARRAY encoder for Parquet #15239

Merged
merged 6 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions cpp/src/io/parquet/page_delta_decode.cu
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,14 @@ CUDF_KERNEL void __launch_bounds__(decode_block_size)
return;
}

if (s->col.logical_type.has_value() && s->col.logical_type->type == LogicalType::DECIMAL) {
// we cannot read decimal encoded with DELTA_BYTE_ARRAY yet
if (t == 0) {
set_error(static_cast<kernel_error::value_type>(decode_error::INVALID_DATA_TYPE), error_code);
}
return;
}

bool const has_repetition = s->col.max_level[level_type::REPETITION] > 0;

// choose a character parallel string copy when the average string is longer than a warp
Expand Down Expand Up @@ -620,6 +628,14 @@ CUDF_KERNEL void __launch_bounds__(decode_block_size)
return;
}

if (s->col.logical_type.has_value() && s->col.logical_type->type == LogicalType::DECIMAL) {
// we cannot read decimal encoded with DELTA_LENGTH_BYTE_ARRAY yet
if (t == 0) {
set_error(static_cast<kernel_error::value_type>(decode_error::INVALID_DATA_TYPE), error_code);
}
return;
}

bool const has_repetition = s->col.max_level[level_type::REPETITION] > 0;

// copying logic from gpuDecodePageData.
Expand Down
Loading
Loading