Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of hash_character_ngrams using warp-per-string kernel #16212
Improve performance of hash_character_ngrams using warp-per-string kernel #16212
Changes from 21 commits
00de3e5
2a00e2e
9bb5600
b4cbafd
20c206e
3761822
84f949b
06c399b
f38ded5
2efb048
0b08a91
2496beb
f7ac0ea
fbbbe90
7bffad4
f7a2689
5e6b54c
cae4bc0
f0a9956
06925ed
6b7cfd9
4fbbf07
88476a8
9c6ce7f
b25403f
899ad1f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking nit: use CUDA native functions instead of STL ones in device code since the former is hardware accelerated.
cuda::std::max
also works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat!