Align DatetimeIndex APIs with pandas 2.x #16367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
| """ | ||
| return self.to_pandas().to_pydatetime() | ||
|
|
||
| def to_julian_date(self) -> Index: |
There was a problem hiding this comment.
Can we add pytests to cover these newly added APIs?
There was a problem hiding this comment.
Sure added tests in the latest commit
…schke/cudf into api/datetimeindex/alignment
wence-
approved these changes
Jul 31, 2024
Comment on lines
2509
to
2512
| if method == "std": | ||
| request.applymarker( | ||
| pytest.mark.xfail(reason="cudf returns imprecise nanoseconds") | ||
| ) |
There was a problem hiding this comment.
nit move this up to the parametrization as:
pytest.param("std", marks=pytest.mark.xfail(...))
Also, do we have an open issue for this? No, but opened #16444
galipremsagar
approved these changes
Jul 31, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly transferring methods that were defined on
Series.dtmethods toDatetimeColumnso it could be reused inDatetimeIndexChecklist