Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cudf.pandas REPL and -c command support #16428

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Enable cudf.pandas REPL and -c command support #16428

merged 11 commits into from
Sep 18, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 29, 2024 •
edited
Loading

Description

This PR enables support for two features:

  • python -m cudf.pandas gives a REPL experience (previously it raised an error)
  • python -m cudf.pandas -c "<commands>" runs the provided commands (previously unsupported)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Jul 29, 2024
@wence-
Copy link
Contributor

wence- commented Sep 5, 2024 •
edited
Loading

For testing python -m cudf.pandas, heredoc is probably your friend:

python -m cudf.pandas << \EOF
print("foo")
EOF

@Matt711 Matt711 self-assigned this Sep 5, 2024
@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Sep 5, 2024
@Matt711 Matt711 marked this pull request as ready for review September 5, 2024 23:54
@Matt711 Matt711 requested a review from a team as a code owner September 5, 2024 23:54
bdice
bdice commented Sep 6, 2024
View reviewed changes
python/cudf/cudf_pandas_tests/test__main__.py Outdated Show resolved Hide resolved
python/cudf/cudf_pandas_tests/test__main__.py Outdated Show resolved Hide resolved
python/cudf/cudf_pandas_tests/test__main__.py Outdated Show resolved Hide resolved
python/cudf/cudf_pandas_tests/test__main__.py Outdated Show resolved Hide resolved
python/cudf/cudf_pandas_tests/test__main__.py Outdated Show resolved Hide resolved
@Matt711 Matt711 added the 2 - In Progress Currently a work in progress label Sep 6, 2024
@Matt711 Matt711 added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Sep 9, 2024
@Matt711 Matt711 requested a review from wence- September 9, 2024 14:50
@bdice bdice self-assigned this Sep 17, 2024
@bdice
Copy link
Contributor Author

bdice commented Sep 17, 2024

@Matt711 Thanks for your help on this. Could you review the last set of modifications I made?

Matt711
Matt711 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdice! The testing and doc changes LGTM. One small suggestion

python/cudf/cudf/pandas/__main__.py Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor Author

bdice commented Sep 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit 57ae3e3 into rapidsai:branch-24.10 Sep 18, 2024
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@wence- wence- Awaiting requested review from wence-

Assignees

@bdice bdice

@Matt711 Matt711

Labels
3 - Ready for Review Ready for review by team cudf.pandas Issues specific to cudf.pandas feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @wence- @Matt711