Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit construction of column subclass instead of build_column when type is known #16470

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

mroeschke
Copy link
Contributor

Description

When we need to construct a column with a specific type, we do not need to go through the indirection of build_column, which matches a column subclass to a passed type, and instead construct directly from the class instead

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 1, 2024
@mroeschke mroeschke requested a review from a team as a code owner August 1, 2024 22:51
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit cc19d8a into rapidsai:branch-24.10 Aug 2, 2024
79 checks passed
@mroeschke mroeschke deleted the ref/rm/build_column branch August 2, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants